fix: skip heavy recursion tests in nightly debug builds#22484
Draft
fix: skip heavy recursion tests in nightly debug builds#22484
Conversation
AztecBot
added
ci-draft
Collaborator
Author
Flakey Tests🤖 says: This CI run detected 1 tests that failed, but were tolerated due to a .test_patterns.yml entry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the recurring nightly barretenberg debug build failure caused by test timeouts.
Root cause:
HonkRecursionConstraintTest,ChonkRecursionConstraintTest, andAvmRecursionInnerCircuitTeststake 400-600s in debug builds, hitting the 600s default timeout. These suites build full recursive circuits which are extremely slow without compiler optimizations.Fix (cherry-picked from merge-train/barretenberg PRs #22446 and #22389):
HonkRecursionConstraintTest,ChonkRecursionConstraintTest, andAvmRecursionInnerCircuitTestssuites in debug buildsHonkRecursionConstraintTestWithoutPredicate/1.GenerateVKFromConstraints(241s, well within timeout) so the debug-onlynative_verification_debugcode path inhonk_recursion_constraint.cppis still exercisedBB_DISABLE_ASSERTS()toChonkRecursionConstraintTest::GenerateRecursiveChonkVerifierVKFromConstraintsto match the pattern used in other heavy testsDebug assertion coverage audit:
HonkRecursionConstraintTest: The retained/1.GenerateVKFromConstraintstest covers thenative_verification_debugpath (#ifndef NDEBUG)ChonkRecursionConstraintTest: AllBB_ASSERT_DEBUGinchonk.cppare disabled byBB_DISABLE_ASSERTS().ChonkTeststampering (separate binary, not skipped) still runsAvmRecursionInnerCircuitTests:BB_ASSERT_LTE(circuit size bounds) is hit on the happy path byAvmRecursiveTestsFailed nightly run: https://github.com/AztecProtocol/aztec-packages/actions/runs/24228497408
ClaudeBox log: https://claudebox.work/s/ad59d50075fdf2f7?run=1